Implement poc_mobile grpc endpoint: submit_enabled_carriers_info #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements the subimt_enabled_carriers_info endpoint to handle enabled carriers information reports. The changes add support for processing and storing enabled carriers data through the existing file sink infrastructure.
- Adds new gRPC endpoint
subimt_enabled_carriers_infowith request/response handling - Integrates
EnabledCarriersInfoReportV1into the file sink system for data persistence - Updates proto dependency to use the carrier enablement branch
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ingest/src/server_mobile.rs | Implements the new gRPC endpoint and adds enabled carriers sink integration |
| ingest/tests/common/mod.rs | Updates test infrastructure to support enabled carriers data flow |
| file_store/src/traits/msg_verify.rs | Adds message verification for enabled carriers requests |
| file_store/src/traits/file_sink_write.rs | Implements file sink functionality for enabled carriers reports |
| file_store/src/file_info.rs | Adds new file type definition for enabled carriers reports |
| Cargo.toml | Updates helium-proto dependency to carrier enablement branch |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ingest/src/server_mobile.rs
Outdated
| Ok(Response::new(BanRespV1 { timestamp_ms })) | ||
| } | ||
|
|
||
| async fn subimt_enabled_carriers_info( |
There was a problem hiding this comment.
Function name has a typo: 'subimt' should be 'submit'
Suggested change
| async fn subimt_enabled_carriers_info( | |
| async fn submit_enabled_carriers_info( |
Copilot uses AI. Check for mistakes.
kurotych
changed the title
bbalser
approved these changes
Sep 24, 2025
michaeldjeffrey
approved these changes
Oct 3, 2025
kurotych
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.